docs: fix incorrect feature name references in gix-transport#2447
Merged
Sebastian Thiel (Byron) merged 1 commit intoGitoxideLabs:mainfrom Feb 25, 2026
Merged
Conversation
Sebastian Thiel (Byron)
approved these changes
Feb 25, 2026
Member
Sebastian Thiel (Byron)
left a comment
Sebastian Thiel (Byron)
left a comment
There was a problem hiding this comment.
Thanks a lot, much appreciated.
Sebastian Thiel (Byron)
force-pushed
the
fix-docs-gix-transport-features
branch
from
77ba987 to
031e959
Compare
- Replace 'blocking-http-transport-reqwest' with correct 'http-client-reqwest' - Add note that HTTPS is NOT supported by default with http-client-reqwest - Users must enable http-client-reqwest-rust-tls or http-client-reqwest-native-tls Fixes GitoxideLabs#2425
Sebastian Thiel (Byron)
force-pushed
the
fix-docs-gix-transport-features
branch
from
031e959 to
f468491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes documentation issues in
gix-transport/Cargo.tomlrelated to thereqwestfeature names:Incorrect feature name references: Replaced
blocking-http-transport-reqwestwith the correcthttp-client-reqwestin the feature documentation comments. These incorrect references were carried over from a March 2024 PR (Remove dep reqwest from gix #1329) that migrated therustlsfeature intogix-transport.Clarified HTTPS support: Added a note to the
http-client-reqwestfeature documentation that HTTPS is NOT supported by default. Users must enable one of:http-client-reqwest-rust-tlshttp-client-reqwest-native-tlsThis addresses user confusion where HTTPS requests would fail with an unhelpful error message when only
http-client-reqwestwas enabled.Related
Fixes #2425
Changes